Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw an error if incorrect ledger is used #3177

Closed
wants to merge 8 commits into from
Closed

fix: throw an error if incorrect ledger is used #3177

wants to merge 8 commits into from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 14, 2024 •
edited
Loading

@rootulp rootulp self-assigned this Mar 14, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2024 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@rootulp rootulp changed the title chore(deps): upgrade to cosmos-sdk v1.20.2-sdk-v0.46.16 fix: throw an error if incorrect ledger is used Mar 14, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 14, 2024

I think we accidentally made a cosmos-sdk patch release with a breaking change @cmwaters

@rootulp
Copy link
Collaborator Author

rootulp commented Mar 14, 2024

I'm taking inspiration from #3162 on all the other places app version needs to be plumbed because it looks like this PR broke a few tests

@rootulp rootulp marked this pull request as ready for review March 28, 2024 16:56
rootulp
rootulp commented Mar 28, 2024
View reviewed changes
cmd/celestia-appd/cmd/root.go
Comment on lines -249 to -251
func(b *baseapp.BaseApp) {
b.SetAppVersion(sdk.Context{}, appconsts.LatestVersion)
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmwaters I'd appreciate your review here. These lines are missing from the main branch so opted to delete them here which resolved some test failures. Was that correct? I don't understand the flow of setting app version before / after the cosmos SDK bump

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in v1, the app version is hardcoded through this exact mechanism (i.e. it's manually set in the constructor). In v2 and onwards, it is read from the genesis file. It could be possible to make the same modifications to celestia-core for v1 that would allow v1.x to also read and set the app version from genesis. However, it's probably easier if you simply keep these lines around which will hardcode the version to 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not actually possible to keep these lines here because v1.x panics on this line. On v1.x, app.ParamStore is not defined before hitting this line.

@rootulp rootulp marked this pull request as draft April 2, 2024 19:11
@rootulp
Copy link
Collaborator Author

rootulp commented Apr 18, 2024

Closing b/c I'm not working on this. The ledger fix is on main so will be released in v2.0.0. If we really need it on a v1.x release then we can re-open this PR.

@rootulp rootulp closed this Apr 18, 2024
@rootulp rootulp mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rootulp @cmwaters